Avoid printing binary request body to stderr during dry-run #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR prevents binary request bodies from being printed to stderr during dry-run operations by adding validation to check if the body is printable before attempting to display it.
Changes:
- Added binary detection logic using
isPrintable()function to validate request bodies before printing - Added warning message when binary request body is detected instead of printing raw binary data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryanfowler
force-pushed
the
dry-run-binary-body
branch
from
c2f94e3 to
a9b2749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.